Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add audioConfig prop to Speech SDK Ponyfill #2491

Merged
merged 5 commits into from
Oct 24, 2019
Merged

add audioConfig prop to Speech SDK Ponyfill #2491

merged 5 commits into from
Oct 24, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Oct 23, 2019 •
edited
Loading

#2481 (ignore branch name -- I have dyslexia?)

Changelog Entry

  • Resolve #2481. Support alternative audio input source by adding audioConfig prop to createCognitiveServicesSpeechServicesPonyfillFactory, by @corinagum, in PR #xxx

Description

This will allow customers (once bug by Speech SDK team is resolved) to manually indicate the microphone to register speech from.

Specific Changes

  • Added audioConfig prop to createCognitiveServicesSpeechServicesPonyfillFactory.js.

@coveralls
Copy link

coveralls commented Oct 23, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 65.299% when pulling 9aa2e90 on corinagum:2184-audioConfig into fab7cd8 on microsoft:master.

compulim
compulim approved these changes Oct 23, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@compulim compulim merged commit c6fbe45 into microsoft:master Oct 24, 2019
@compulim compulim deleted the 2184-audioConfig branch October 24, 2019 06:36
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support alternative audio input source (Bluetooth adapter)
3 participants
@corinagum @coveralls @compulim