Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activity grouping for accessibility #3146

Merged
merged 5 commits into from
May 11, 2020
Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented May 5, 2020

Fixes #3133.

Changelog Entry

Fixed

  • Fixes #3133. Associate ARIA labels with buttons in hero card and Adaptive Cards, by @compulim in PR #3146.
    • Remove browser-based detection from <ScreenReaderText> because it is no longer needed.
    • After stripping Markdown syntax for accessibility labels, cache the result to improve rendering performance.
    • Skip stripping Markdown for non-Markdown text content.

Description

When AT is reading Adaptive Card attachment, the label (<ScreenReaderText>) is not read correctly.

On top of this fix, we also need Adaptive Card bump that would remove tabindex="0' from their DOM node.

Specific Changes

Please refer to changelog above for specific changes.


  • Testing Added
    • Manual testing steps are required
      1. Bot send 2 different hero cards (type herocard qna to MockBot)
        • The activity which contain the hero cards must have a text on it
        • The content of the hero card must have 2 card actions
      2. Launch Narrator or other AT
      3. Focus on the first button of first hero card
      4. Press TAB to focus to the first button of the second hero card
      5. Make sure AT read "Bot said, second activity text. Sent at ... First button"
      6. Press TAB to focus to the second button of the second hero card
      7. Make sure AT read "Second button"
      8. Press SHIFT + TAB to focus to the second button of the first hero card
      9. Make sure AT read "Bot said, first activity text. Sent at ... Second button"

Copy link
Contributor

@beyackle beyackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. 🚢!

@compulim compulim merged commit 6462ef4 into microsoft:master May 11, 2020
@compulim compulim deleted the fix-3133 branch May 11, 2020 05:28
@compulim compulim mentioned this pull request May 12, 2020
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11y] [Issue 3] Need clear button labels within chat
2 participants