Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#9331] Substring function contains wrong tooltip information #9351

Merged
merged 7 commits into from
May 16, 2024

Conversation

ceciliaavila
Copy link
Collaborator

Description

This PR fixes the tooltip description of the Substring function to reflect the current parameters.

Note: we tested the case reported in the issue:

a length from the startPos that surpasses the length of the string will generate an out of range exception, not be taken as the max length of the string.

but the exception was not thrown so we didn't update that part of the description.

Task Item

Fixes #9331

Screenshots

These images show the before and after.
image

BruceHaley
BruceHaley previously approved these changes Sep 8, 2022
@erquirogasw
Copy link

Hello @OEvgeny ,

We reach out to you because we are having issues with Prs modifying extensions in BotFramework-Composer, and we saw that you created some successful PRs updating the same packages (# 9396).
Our PRs fail with the error: YN0028-The lockfile would have been modified by this install, which is explicitly forbidden.
And we tried different approaches to build the project and generate the yarn.berry.lock file but we couldn't make it work.
We would like to know the steps you follow to build the project after updating the code of an extension, and if there's any extra configuration for the checksums to be properly updated.

Thanks!

@OEvgeny
Copy link
Collaborator

OEvgeny commented Oct 18, 2022

@erquirogasw the yarn build:dev command after some changes are made to shared packages usually works for me. If the sums didn't get updated, you could try removing node_modules from the extension package folder.

@erquirogasw
Copy link

@OEvgeny we executed the yarn build:dev command in Composer/packages/tools/built-in-functions to update the yarn files related to the changes of this PR and multiple libraries were modified in extensions (azurePublish, azurePublishNew, etc). We also tried removing the node_modules folder but more libraries were updated, compared to the ones we modified.
We updated the PR with the mentioned changes in case you notice any steps that we aren't executing correctly.

@OEvgeny
Copy link
Collaborator

OEvgeny commented Oct 19, 2022

@erquirogasw please ensure you pulled the latest version from main before updating the sums.

@erquirogasw
Copy link

@OEvgeny, we cloned the repository again and after running yarn install and yarn build:dev in the Composer/ folder, we noticed that several yarn-berry.lock files were modified in extensions/. We didn't introduce any changes, just built the project on main branch.
We'll try building the project directly from the GitHub action to discard an issue on our machine.

image (152)

@OEvgeny
Copy link
Collaborator

OEvgeny commented Oct 20, 2022

This might be platform-related issue. Yarn has an issue with hash persistence across platforms unfortunately.

@ceciliaavila ceciliaavila force-pushed the southworks/update/substring-tooltip branch from 45fd507 to 20a82fe Compare October 27, 2022 14:45
@coveralls
Copy link

coveralls commented Oct 27, 2022

Coverage Status

coverage: 54.388%. remained the same
when pulling 551b7ec on southworks/update/substring-tooltip
into e36db33 on main.

@ceciliaavila
Copy link
Collaborator Author

Hi @BruceHaley, we have the E2E tests failing in this PR and in a few others. Also, there's a component governance error, but we don't have access to the pipeline to understand the problem and fix it. Could you help us with this?
Thanks!

@OEvgeny
Copy link
Collaborator

OEvgeny commented Oct 28, 2022

@ceciliaavila e2e pipeline failure seem unrelated to the PR. You can run e2e tests locally for more details

@OEvgeny
Copy link
Collaborator

OEvgeny commented Apr 26, 2024

Should be good to go after related package lock hash updates

@OEvgeny OEvgeny merged commit 0b503f9 into main May 16, 2024
5 checks passed
@OEvgeny OEvgeny deleted the southworks/update/substring-tooltip branch May 16, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Substring function contains wrong tooltip information
6 participants