fix: Delete & Undo on actions with LG templates doesn't bring back the LG content #4740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath,
tonyanziano and
yeze322
as code owners
boydc2014
previously approved these changes
Nov 10, 2020
This reverts commit 1b1481e.
…amework-Composer into fix/async-delete
boydc2014
approved these changes
Nov 10, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Nov 12, 2020
* settingsPage: remove useless files Corrected types Support undo/redo for skill (microsoft#4754) fix UT feat: Diagnostics Page (microsoft#4457) set defaultLanguage as active language if active language is deleted fix: correct URL when switching page modes (microsoft#4736) fix: do not stub __dirname for node extensions (microsoft#4749) chore: bundle extensions (microsoft#4745) fix: Delete & Undo on actions with LG templates doesn't bring back the LG content (microsoft#4740) feat: update sdk package to 4.11.0 (microsoft#4741)
Merged
This was referenced Nov 13, 2020
Merged
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…e LG content (microsoft#4740) * async action delete API * async DialogEditApi * wait action deletion * update type and add registerEditorAPI * fix unit tests * add commit for lg update * Revert "add commit for lg update" This reverts commit 5e6a4e9f3b59acb295ec8b4cb583783d8b073f2c. * update the lu and lg commit time * update the debounce option Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The removeLgTemplates is asynchronous, we need to wait before committing changes to the undo history.
In lu and lg inline editor, Add commit when the content changed.
Task Item
#minor
Screenshots