fix: generate correct URLs for root bots #4614
Conversation
beyackle
requested review from
a-b-r-o-w-n,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
beyackle
changed the title
| @@ -279,7 +279,7 @@ export const ProjectTree: React.FC<Props> = ({ | |||
| displayName: dialog.displayName, | |||
| isRoot: dialog.isRoot, | |||
| projectId: rootProjectId, | |||
| skillId: skillId, | |||
| skillId: skillId === rootProjectId ? undefined : skillId, | |||
There was a problem hiding this comment.
@beyackle I see a bug where I click on a skill's dialog file url changes correctly to http://localhost:3000/bot/25141.842060596977/skill/5927.301138798824/dialogs/googlekeepsync?selected=triggers[%22376720%22] . Navigate to a different page and come back to the DesignPage. The url is an invalid URL. It needs to set the url obtained from the previous designPageLocationState right?
There was a problem hiding this comment.
This looks to me like a problem in the sidebar - when I have a skill open (so, the URL is /bot/<bot Id>/skill/<skill Id>) and click on the sidebar button, it takes me to a URL with /bot/<skill Id>/ in it, and then clicking back into Design keeps that around. Single-bot projects don't have this problem. The reason this change is going into main and not the feature branch is that undo/redo was breaking even in the single-bot case, right?
There was a problem hiding this comment.
This fix has no relation to undo/redo. The URL was broken irrespective of whether we were doing Undo/redo.
There was a problem hiding this comment.
This doesn't seem to be an issue with the sidebar though. DesignPageLocation state stores the current focussed actions etc that are particular to the design page. On rendering the designPage it should always use the currentProjectId state and parse the designPagelocation state to set the URL correctly?
Description
This fixes a small glitch in generating URLs for the links; dialogs and triggers that belong to the root of a botProject now generate links that look like the older non-botProject ones, which should fix some issues with undo/redo.
Task Item
#minor
Screenshots