Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed pva publish base url bug #4538

Merged
merged 3 commits into from
Oct 27, 2020
Merged

fix: Fixed pva publish base url bug #4538

merged 3 commits into from
Oct 27, 2020

Conversation

tonyanziano
Copy link
Contributor

Description

The baseUrl that is provided from PVA in the publishing profile configuration has the form:

https://bots.int.customercareintelligence.net/

with just the host name. So I adjusted the constant base URLs to adhere to this shape.

#minor

@coveralls
Copy link

coveralls commented Oct 26, 2020

Coverage Status

Coverage remained the same at 55.025% when pulling 9967c81 on toanzian/fix/pva-url into 2e0f35c on main.

@tonyanziano tonyanziano merged commit b6acb0d into main Oct 27, 2020
@tonyanziano tonyanziano deleted the toanzian/fix/pva-url branch October 27, 2020 00:23
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants