feat: Change docker base image to Ubuntu-20.04 #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdonke
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
boydc2014
approved these changes
Oct 26, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Ignoring .git folder for docker build * changing base image to ubuntu * adding verbose to health check on github actions * fix varaible name Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the base image to ubuntu, instead of node with Debian.
Instead of running a Node+Debian image and installing the .NET Core, I used a .NET Core image and installed the NodeJS package.
The base image size is 400Mb smaller.
Rebasing from MAIN branch, since branching from ORCHESTRATOR branch was returning code errors.
Task Item
#minor
Tests
Validated the build and push using Az DevOps pipeline:
