Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: azure publish failed #4423

Merged
merged 3 commits into from
Oct 19, 2020
Merged

fix: azure publish failed #4423

merged 3 commits into from
Oct 19, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Oct 19, 2020 •
edited
Loading

Description

In #4351 we have updated the bf-cli version. But the azure publish copied the build logic from the server and client. It will fail if we update the bf-lu version.

  1. use previous bf-lu version in azure publish as a short term fix.
  2. The luis settings' structure changed (lubuild result) in previous PR. update the get function.
  3. update the azure plugin relative path. (the plugins folder path changed in chore: move plugins folder outside of Composer #4399).
  4. update the down-sampling library version

Task Item

#minor

Screenshots

@coveralls
Copy link

coveralls commented Oct 19, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 55.732% when pulling d0ba695 on lei9444:azurepublish into 075b6a9 on microsoft:main.

@boydc2014
Copy link
Contributor

@luhan2017 @VanyLaw can you help review this one?

luhan2017
luhan2017 previously approved these changes Oct 19, 2020
View reviewed changes
@boydc2014 boydc2014 added the Approved to merge approved, waiting to be merged label Oct 19, 2020
boydc2014
boydc2014 previously approved these changes Oct 19, 2020
View reviewed changes
@boydc2014
Copy link
Contributor

@lei9444 please address the conflict

@lei9444 lei9444 dismissed stale reviews from boydc2014 and luhan2017 via 4e6b980 October 19, 2020 11:16
@cwhitten cwhitten merged commit 2fc45bc into microsoft:main Oct 19, 2020
@lei9444 lei9444 deleted the azurepublish branch November 4, 2020 04:47
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@lei9444 @cwhitten
fix azure publish (microsoft#4423)
d8c433e 
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@boydc2014 boydc2014 boydc2014 left review comments

@luhan2017 luhan2017 luhan2017 left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
Approved to merge approved, waiting to be merged Team: Platform Team: Runtime & Publishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lei9444 @coveralls @boydc2014 @cwhitten @luhan2017