Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add self contained config in dotnet publish #4391

Merged
merged 7 commits into from
Oct 21, 2020
Merged

Conversation

zidaneymar
Copy link
Contributor

@zidaneymar zidaneymar commented Oct 15, 2020

Description

Under linux environment, webapp bot couldn't be started up after dotnet publishing.
This issue only occurs at 'linux' env.
For runtime identifier: please refer to this doc: https://docs.microsoft.com/en-us/dotnet/core/rid-catalog

Task Item

fixes #4348

Screenshots

Copy link
Contributor

@luhan2017 luhan2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an param for deployment, and default it to windows? Later if customer want to have a customized deployment (for example, linux vm), they can just set the param in the script.

@zidaneymar
Copy link
Contributor Author

Can we add an param for deployment, and default it to windows? Later if customer want to have a customized deployment (for example, linux vm), they can just set the param in the script.

OK, I will add it today.

@zidaneymar zidaneymar marked this pull request as ready for review October 20, 2020 09:23
@coveralls
Copy link

coveralls commented Oct 20, 2020

Coverage Status

Coverage remained the same at 55.362% when pulling 63f1253 on qika/fixRuntime into b2cd261 on main.

@cwhitten
Copy link
Member

@zidaneymar @luhan2017 I'd like to verify that this won't break existing publishing profiles without this new shape, and allow users with old publishing profiles to add this new parameter.

@zidaneymar
Copy link
Contributor Author

Tested 4 different scenarios:
Composer hosting on linux publish to linux operating system.
Composer hosting on linux publish to windows operating system.
Composer hosting on windows publish to linux operating system.
Composer hosting on windows publish to windows operating system.

@luhan2017
Copy link
Contributor

@zxyanliu, this may need a doc update, users needs to understand what this field means and how to use it.

@zxyanliu
Copy link
Contributor

luhan2017 commented 7 hours ago
@zxyanliu, this may need a doc update, users need to understand what this field means and how to use it.

No problem, let's discuss in detail offline.

@cwhitten cwhitten merged commit d18b0fb into main Oct 21, 2020
@cwhitten cwhitten deleted the qika/fixRuntime branch October 21, 2020 17:02
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot App deployed by Composer cannot start
5 participants