refactor: change method of installing extensions #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested review from
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
tonyanziano
suggested changes
Oct 2, 2020
tonyanziano
reviewed
Oct 2, 2020
tonyanziano
previously approved these changes
Oct 2, 2020
tonyanziano
approved these changes
Oct 2, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* update default extensions directory * load builtin and remote extensions the same way * refactor installing remote extensions * update default extension manifest location * refactor removing an extension * add tests for npm * add search method to npm module * improve error logging * add tests for downloading extension * refactor manager tests * deprecate extendsComposer * add test for loadFromDir * add more manager tests * use npm registry api to search * omit installed extensions from search * add getBundle test * remove rimraf, use remove from fs-extra * make remvoing builtin a no-op * add rimraf back to dev deps * fix security warning by resolving to terser-webpack-plugin version * ensure extensions cannot be installed outside remoteDir * supress lgtm error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Directly download and unpack extensions using the npm registry api. This enables a unified approach to loading built-in vs remote extensions and results in more transparent installation output.
Task Item
#minor