fix: Move skill settings into settings.skillConfiguration #4312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e existing skill object Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
carlosscastro,
cwhitten,
GeoffCoxMSFT,
hatpick,
luhan2017 and
tonyanziano
as code owners
added 2 commits
October 1, 2020 15:40
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…soft/BotFramework-Composer into srravich/fix-runtime-start
tdurnford
reviewed
Oct 1, 2020
tdurnford
reviewed
Oct 1, 2020
tdurnford
reviewed
Oct 1, 2020
beyackle
reviewed
Oct 1, 2020
| isSkill: false, | ||
| allowedCallers: ['*'], | ||
| }, | ||
| skill: {}, |
There was a problem hiding this comment.
Is there a reason to keep this around even though it's empty?
There was a problem hiding this comment.
Yeah. Its the object to which we append new skills from the UI. I presonally prefer to keep it so that when new bots are created by default it shows as an empty object and we just keep adding to the dictionary.
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
changed the title
carlosscastro
approved these changes
Oct 1, 2020
tdurnford
approved these changes
Oct 1, 2020
cwhitten
approved these changes
Oct 1, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Item
Moved skill settings from settings.skill into settings.skillConfiguration. The reason being settings.skill is being used by Composer to maintain the list of skills consumed by the Root Bot. This fix would just allow the C# runtime to get the skills config.
@carlosscastro is tracking this functionality to be ported into the JS runtume
@tonyanziano This is the fix for the faulty skill config
#minor