Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade to recoil to version 0.0.13 #4270

Merged
merged 6 commits into from
Sep 29, 2020
Merged

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Sep 25, 2020

Description

Upgrade the recoil to version 0.0.13
The recoil depends on react 16.13.1, so update the react to the latest

Task Item

closes #4223
closes #4267

Screenshots

@a-b-r-o-w-n
Copy link
Contributor

@srinaath do you think you could pick this up today? There are some TS errors in the client build, otherwise this looks good to me. Since you have the most familiarity with recoil in our codebase, would you mind doing a functional test of this?

@srinaath
Copy link
Contributor

srinaath commented Sep 25, 2020

@lei9444 

I tried LU/LG/QNA editing, Creation, Opening, Delete bot, Skills, Publish workflows. They all functionally look good. In addition, the upgrade got rid of the warnings when using selectors. @hatpick

@coveralls
Copy link

coveralls commented Sep 27, 2020

Coverage Status

Coverage increased (+0.02%) to 55.667% when pulling ed1e998 on lei9444:recoil into 1b2b274 on microsoft:main.

@cwhitten cwhitten merged commit 3aeac2d into microsoft:main Sep 29, 2020
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
@lei9444 lei9444 deleted the recoil branch February 1, 2021 02:08
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* update the recoil to 0.0.13

* fix lint

* remove @type/recoil

* fix typecheck

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser console: Error/Warning: Cannot update a component from... Upgrade to recoil to version 0.0.13
6 participants