feature: Adding VA template custom creation UI #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h has been removed
…ient package creation flow, Moved some UI assets to shared UI lib for cross workspace reuse, added creation UI experience for va-core template
Moved to standard styling practices, normalized file content structure, added formatMessage() to UI strings, misc clean up
pavolum
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
hatpick
reviewed
Sep 18, 2020
Composer/packages/client/src/components/CreationFlow/CreationFlow.tsx
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Sep 18, 2020
hatpick
reviewed
Sep 18, 2020
...kages/ui-plugins/virtual-assistant-creation/src/components/VirtualAssistantCreationModal.tsx
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Sep 18, 2020
...kages/ui-plugins/virtual-assistant-creation/src/components/VirtualAssistantCreationModal.tsx
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Sep 18, 2020
Composer/packages/ui-plugins/virtual-assistant-creation/src/shared/constants.ts
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Sep 18, 2020
Composer/packages/ui-plugins/virtual-assistant-creation/tsconfig.json
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Sep 18, 2020
Composer/packages/ui-plugins/virtual-assistant-creation/src/components/provisionSummaryPage.tsx
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Sep 18, 2020
Composer/packages/ui-plugins/virtual-assistant-creation/src/components/provisionSummaryPage.tsx
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Sep 18, 2020
Composer/packages/ui-plugins/virtual-assistant-creation/src/components/newBotPage.tsx
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Sep 18, 2020
Composer/packages/ui-plugins/virtual-assistant-creation/src/components/newBotPage.tsx
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
reviewed
Oct 7, 2020
a-b-r-o-w-n
reviewed
Oct 7, 2020
Composer/packages/ui-plugins/virtual-assistant-creation/src/components/configSummaryPage.tsx
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
reviewed
Oct 7, 2020
Composer/packages/ui-plugins/virtual-assistant-creation/src/models/stateModels.ts
Show resolved
Hide resolved
Implemented local state relationship to prevent excessive rerenders
… performance. minor clean up of interface and file names
GeoffCoxMSFT
previously approved these changes
Oct 8, 2020
GeoffCoxMSFT
approved these changes
Oct 13, 2020
hatpick
approved these changes
Oct 13, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Adding va core template plug in with corresponding plugin build steps * Adding env variable feature flag around VA=Core template * removing unused code that was initially added for custom runtime which has been removed * Added creation UI workspace which is linked to and referenced from client package creation flow, Moved some UI assets to shared UI lib for cross workspace reuse, added creation UI experience for va-core template * Minor styling changes * Cleaning up code for review: Moved to standard styling practices, normalized file content structure, added formatMessage() to UI strings, misc clean up * Cleaning up unused changes * removing bot type tile * removing bot type tile * Making requested PR changes, general clean up, conversion of interfaces to types, adding error catching * Converting props types to intersaction with reach router, adding await back to createProject function * Fixing files to follow repoo linting rules * Changed post creation logic to execute on useEffect as opposed to reliance on await * resolve reentry bug * removing unused function * Fixing linting errors * resolve reentry bug * Fixing reference * Updating react version in creation extension * Updating react version in creation extension * Making PR changes * Fixed non static formatMessage calls * minor syntax refactoring * Refactoring state management for more modular state. Implemented local state relationship to prevent excessive rerenders * Making additional state management changes for better readability and performance. minor clean up of interface and file names * Fixing file naming * Formatting template strings for localization * changing ReachRouter version dpendency to match client reach/router version * update Azure Publish yarn.lock * Updating reach router version and tamplate name Co-authored-by: Patrick Volum <pavolum@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consists of the custom creation UI portion of the VA template (template code in PR #4140 ). fixes #4142.
Feature break down: