feat: State management support for loading mutiple projects #4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Renaming functions Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Shell api updated Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> All unit tests ans integration tests working now Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…oser into srravich/bot-projects-recoil
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…rosoft/BotFramework-Composer into srravich/bot-projects-recoil
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…rosoft/BotFramework-Composer into srravich/bot-projects-recoil
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…oser into srravich/bot-projects-recoil Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> # Conflicts: # Composer/packages/lib/shared/src/skillsUtils/index.ts
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick and
tonyanziano
as code owners
…oser into srravich/bot-projects-recoil Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> # Conflicts: # Composer/packages/client/src/pages/design/exportSkillModal/index.tsx
added 4 commits
September 16, 2020 11:25
…oser into srravich/bot-projects-recoil-main
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
beyackle
suggested changes
Sep 16, 2020
Composer/packages/client/src/recoilModel/persistence/__test__/FilePersistence.test.ts
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/recoilModel/dispatchers/__tests__/multilang.test.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/recoilModel/dispatchers/__tests__/dialog.test.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/recoilModel/undo/__test__/undoHistory.test.ts
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/recoilModel/undo/__test__/undoHistory.test.ts
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/recoilModel/dispatchers/__tests__/MeetingVA.botProject.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
|
I tested the create bot, delete bot, save as, copy, paste, update dialog, lu, lg and setting. all this parts work well |
added 5 commits
September 17, 2020 01:01
…oser into srravich/bot-projects-recoil Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> # Conflicts: # Composer/packages/client/__tests__/components/skill.test.tsx # Composer/packages/client/src/pages/design/DesignPage.tsx # Composer/packages/client/src/pages/skills/index.tsx # Composer/packages/client/src/recoilModel/dispatchers/__tests__/skill.test.ts # Composer/packages/client/src/recoilModel/dispatchers/skill.ts
Remove fit, it on tests Localization reverts Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
beyackle
reviewed
Sep 17, 2020
added 2 commits
September 17, 2020 11:03
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
beyackle
approved these changes
Sep 17, 2020
yeze322
added a commit
to yeze322/BotFramework-Composer
that referenced
this pull request
Sep 24, 2020
Merged
yeze322
added a commit
that referenced
this pull request
Jan 27, 2021
* chore: move TriggerCreationModal to folder * chore: move styles into styles.ts * chore: move validators out * Extract dropdown options as constants * remove outdated dropdown option generators * don't re-declare SDKKinds as type key * remove initialError, fix tslint * fix warning icon size * refactor show warning logic * move static func outside TriggerModal * refactor: move trigger widget out of Modal * replay changes in #4117 'mutiple projects' * fix a wrong import path * refactor: extract TriggerDropdownGroup * define builtinSchema * TriggerOptionTree * remove duplicated $kinds * link leaf ndoe to parent node * migrate to option tree * fix a React grammar * rename builtinSchema * refactor the warning icon logic of trigger modal * remove unreferenced utils * add a todo * fix UT by adding data-testid * declare TriggerUISchema in extension * use trigger uischema from extension context * check trigger option existence * sort trigger dropdown labels * move root text out of tree utils * pass in option compare fn * add UT for triggerOptionTree * align icon size with main * migrate 1.2 PVA logic * use 'Boolean' to filter trigger menus Co-authored-by: Andy Brown <asbrown002@gmail.com> * wrap trigger UI Schema with formatMessage * add 'px' unit to styles * add trigger menu order * 'order' property to manage trigger order * early returning & add comments * avoid duplicated iteration and add comments * fix trigger modal UT * lint * replay Ben's commit * CI fix Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* chore: move TriggerCreationModal to folder * chore: move styles into styles.ts * chore: move validators out * Extract dropdown options as constants * remove outdated dropdown option generators * don't re-declare SDKKinds as type key * remove initialError, fix tslint * fix warning icon size * refactor show warning logic * move static func outside TriggerModal * refactor: move trigger widget out of Modal * replay changes in microsoft#4117 'mutiple projects' * fix a wrong import path * refactor: extract TriggerDropdownGroup * define builtinSchema * TriggerOptionTree * remove duplicated $kinds * link leaf ndoe to parent node * migrate to option tree * fix a React grammar * rename builtinSchema * refactor the warning icon logic of trigger modal * remove unreferenced utils * add a todo * fix UT by adding data-testid * declare TriggerUISchema in extension * use trigger uischema from extension context * check trigger option existence * sort trigger dropdown labels * move root text out of tree utils * pass in option compare fn * add UT for triggerOptionTree * align icon size with main * migrate 1.2 PVA logic * use 'Boolean' to filter trigger menus Co-authored-by: Andy Brown <asbrown002@gmail.com> * wrap trigger UI Schema with formatMessage * add 'px' unit to styles * add trigger menu order * 'order' property to manage trigger order * early returning & add comments * avoid duplicated iteration and add comments * fix trigger modal UT * lint * replay Ben's commit * CI fix Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first leg of the work to support multiple projects in Composer. This work lets our state management to use atomFamilies in Recoil for botstates. This PR does not add net new functionality but sets up the Bot Project work which wil coming in succesive PR's
Fixes #4031