Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke test showing OOM due to recursive log capture on Wildfly #3796

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

trask
Copy link
Member

@trask trask commented Jul 23, 2024

No description provided.

@trask trask added this to the v3.5.4 milestone Jul 23, 2024
@trask trask force-pushed the add-oom-test branch 7 times, most recently from add4a68 to 91832ae Compare July 24, 2024 20:54
@trask trask marked this pull request as ready for review July 24, 2024 21:14
// System.out back to a logging library which is itself instrumented by the Java agent
//
// see OutOfMemoryWithDebugLevelTest for repro that will fail without this code
CallDepth callDepth = CallDepth.forClass(LoggerProvider.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary to use CallDepth here? Log makes sense. BatchItemProcessor is used for span and metrics too.
we passed a copy of BatchItemProcessor into AgentLogExporter.

Copy link
Member Author

@trask trask Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method is run in a different thread (so the thread local doesn't carry over to here)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add it as comment?

@jeanbisutti jeanbisutti merged commit 4393cd1 into main Jul 25, 2024
88 checks passed
@jeanbisutti jeanbisutti deleted the add-oom-test branch July 25, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants