Reduce logging #3564
Merged
Reduce logging #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Mar 1, 2024
| @@ -236,7 +236,7 @@ private BatchItemProcessor initBatchItemProcessor( | |||
| if (tempDir == null) { | |||
| telemetryPipelineListener = | |||
| new DiagnosticTelemetryPipelineListener( | |||
| "Sending telemetry to the ingestion service", false, " (telemetry will be lost)"); | |||
| "Sending telemetry to the ingestion service", true, " (telemetry will be lost)"); | |||
There was a problem hiding this comment.
this looks like a bug, 3rd arg isn't even used when 2nd arg is false
There was a problem hiding this comment.
tempDir is null.. written to disk is not possible. retries will be false. i don't get it why it becomes true.
There was a problem hiding this comment.
2nd arg controls logging, not writing to disk
jeanbisutti
approved these changes
Mar 1, 2024
heyams
reviewed
Mar 7, 2024
| @@ -245,8 +245,8 @@ private BatchItemProcessor initBatchItemProcessor( | |||
| // will log if that retry from disk fails | |||
| new DiagnosticTelemetryPipelineListener( | |||
| "Sending telemetry to the ingestion service", | |||
| true, | |||
| " (telemetry will be stored to disk and retried)"), | |||
| false, | |||
There was a problem hiding this comment.
not get it why it's false here.
There was a problem hiding this comment.
so that we only log the 2nd time a batch fails (when retrying from disk)
heyams
approved these changes
Mar 20, 2024
heyams
reviewed
Mar 20, 2024
| @@ -236,17 +236,15 @@ private BatchItemProcessor initBatchItemProcessor( | |||
| if (tempDir == null) { | |||
| telemetryPipelineListener = | |||
| new DiagnosticTelemetryPipelineListener( | |||
| "Sending telemetry to the ingestion service", false, " (telemetry will be lost)"); | |||
| "Sending telemetry to the ingestion service", true, " (telemetry will be lost)"); | |||
| } else { | |||
| telemetryPipelineListener = | |||
| TelemetryPipelineListener.composite( | |||
| // suppress warnings on retryable failures, in order to reduce sporadic/annoying | |||
There was a problem hiding this comment.
please update the comment.. this is not what it's actually doing
There was a problem hiding this comment.
I think the comment is correct, can you double check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.