Add a config to disable all logging appenders #3208
Conversation
| import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
|
||
| @UseAgent("disabled_applicationinsights.json") | ||
| abstract class JavaUtilLoggingDisabledTest { |
There was a problem hiding this comment.
and then can remove all the subclasses (similar to the other disabled tests, no need to run these tests against envs)
| abstract class JavaUtilLoggingDisabledTest { | |
| @Environment(TOMCAT_8_JAVA_8) | |
| class JavaUtilLoggingDisabledTest { |
There was a problem hiding this comment.
the purpose of doing subclass is to test all java versions.. this will cover one case?
our repo has this setup everywhere though
i can make the change but i think it needs to be consistent
There was a problem hiding this comment.
check the other *DisabledTest smoke tests, they also only test one case
...ging/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JavaUtilLoggingTest.java
Outdated
Show resolved
Hide resolved
| @WebServlet("/testDisabled") | ||
| public class JavaUtilLoggingDisabledServlet extends HttpServlet { | ||
|
|
||
| private static final Logger logger = Logger.getLogger("smoketestapp"); | ||
|
|
||
| protected void doGet(HttpServletRequest request, HttpServletResponse response) { | ||
| logger.log(Level.WARNING, "this message will get suppressed."); | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't think we need a separate Servlet for these tests, can just hit the same servlet that the normal test does (this is how other *DisabledTest smoke tests work)
There was a problem hiding this comment.
i followed the existing setup.. one test per servlet. i think we can clean up later for all
There was a problem hiding this comment.
i noticed those are spring boot apps. not servlet. we can chat about it in tomorrow's standup
No description provided.