Fix startup profiling #2092
Merged
Fix startup profiling #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 95b86e7 into 836e268 - view on LGTM.com new alerts:
|
heyams
approved these changes
Feb 7, 2022
heyams
added a commit
that referenced
this pull request
Feb 9, 2022
* Support Statsbeat in EU regions (#2082) * Use a diff statsbeat ikey in eu regions * Use lowercase * Fix spotless * Reserve statsbeat config when applicable * Make test easier to understand * Remove unused constants * Decouple TelemetryClient * Add comments * Refactor * Fix spotless * Remove assignment * Fix tests * Convert url to string * Use regex * Strict protocol * No need to escape dash * Remove escape * Add a startup profiler for debugging (#2085) * Add StartupProfiler * Fix errorprone * Fix spotless * Invoke before premain Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Create dump in applicationinsights folder * Show the full path of the dump * Fix lgtm * Allow sout * Fix lgtm * Supress systemout at the method level * Fix style complain * Address comments * Fix spotless * Address comments * Return when exception occurs * Remove comment Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Use getBoolean for system property Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Fix startup profiling (#2092) * Fix startup profiling * errorprone * Shorten host property in network statsbeat (#2087) * Shorten host * Use regex * Fix spotless * Strict protocol * Remove sout debugging * Remove escape . * Send endpointUrl when region is not found * Turn off oshi logging (#2086) * Turn off oshi logging * Update oshi logger level * Don't mark throttle as error (#2079) * Update azure-core dependency (#2095) Co-authored-by: Helen Y <56097766+heyams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Startup profiling isn't writing out anything to the file because the PrintWriter is constructed in a try-with-resources block and so getting closed before it can be written to.
Also added a max 10 minute limit for startup profiling, so the file doesn't get enormous if someone forgets about it.