add a unique id for GC events so that events from a single JVM can be grouped #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnoliver
requested review from
heyams,
kryalama,
trask and
xiao-lix
as code owners
johnoliver
changed the title
johnoliver
changed the title
trask
reviewed
Jun 1, 2021
Comment on lines
+28
to
+29
| //TODO if/when Application Insights adds a unique ID that represents a single JVM, pull that ID here | ||
| private static final String JVM_INSTANCE_UID = UUID.randomUUID().toString(); |
There was a problem hiding this comment.
does role instance work for this? or is it required to get a different different value on each restart of a single JVM?
There was a problem hiding this comment.
it needs to be different for every restart as the gc starts again from scratch every time the JVM is restarted, and we need to analyse single JVMs
trask
approved these changes
Jun 2, 2021
core/src/main/java/com/microsoft/applicationinsights/internal/profiler/GcEventMonitor.java
Show resolved
Hide resolved
…profiler/GcEventMonitor.java
trask
pushed a commit
that referenced
this pull request
Jun 7, 2021
heyams
added a commit
that referenced
this pull request
Jun 8, 2021
* Support agentmain (#1687) * Use ProfilerEndpoint from connection string (#1694) * Add test to make sure no non-daemon threads (#1695) * Better EventHubs support (#1698) * Reduce spammy error (#1701) * Emit Profiler start/stop events (#1706) * 2.x SDK explicit operation id / operation parent id should take precedence (#1708) * Support explicit operation id/parentId from 2.x * Test * Release 3.1.1-BETA.2 (#1709) * Prepare for a new beta release * Fix a typo * Reword Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Hide super advanced feature. Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Better Azure Service Bus support (#1710) * Use main as the default branch from now on (#1715) * Retry webflux tests 3 times when it's failing (#1712) * Retry webflux 3 times when it's failing * print stack trace when the final retry fails * Reword Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Update to latest OTel (#1719) * Update OTel * Suppress 2.x request name handler * Remove retry * Suppress CDS Profile endpoint warning in smoke tests * Bump timeout to avoid sporadic failures * Prepare 3.1.1-BETA.3 release (#1723) * Fix App Map display of unknown dependencies (#1716) * Fix App Map display of unknown dependencies * Add net peer mapping to target also * Add clarifying comment * Fix agent jar size (#1724) * Fix agent jar size * Bump version * Add roleName to profile metadata (#1725) * add a unique id for GC events so that events from a single JVM can be grouped (#1721) * Fix 2.x interop of timestamps (#1726) * Fix 2.x interop of timestamps * Add smoke test * Bump version * add logprocessor to agent (#1713) * add logprocessor to agent * comments addressed, added smoketest for log processor, fixed bug in telemetryprocessorOpenTelemetryConfigurer * StringBuffer -> StringBuilder * addressing comments * removed lognames, fixed smoke test * replace name with body in log processor, address comments Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: John Oliver <1615532+johnoliver@users.noreply.github.com> Co-authored-by: Helen Y <56097766+heyams@users.noreply.github.com> Co-authored-by: kryalama <66494519+kryalama@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.