Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #1520

Merged
merged 58 commits into from
Mar 2, 2021
Merged

Remove unused code #1520

merged 58 commits into from
Mar 2, 2021

Conversation

trask
Copy link
Member

@trask trask commented Mar 1, 2021

Primarily based on Intellij inspections.

There's one fix also in here

@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2021

This pull request introduces 1 alert when merging 7bb859b into 0fd3d86 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2021

This pull request introduces 1 alert when merging 192c11d into 0fd3d86 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2021

This pull request introduces 1 alert when merging 8573503 into 0fd3d86 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

* instances created in the application.
*
* @return True if tracking is disabled.
*/
public boolean isTrackingDisabled() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's only used for code generation in TelemetryClientClassFileTransformer

Copy link
Contributor

@heyams heyams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 9ce9498 into master Mar 2, 2021
@trask trask deleted the trask/remove-unused-code branch March 2, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants