Remove StatsdConfig.queueSize() #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose we should deprecate instead. Technically this would be a breaking change, though clearly no value is derived from it. |
|
@jkschneider Thanks for the feedback! I created another PR for deprecation against the 1.0.x branch. |
|
@izeye can you rebase this on 2.0.x now that we have a branch for 2.0 work? Thanks! |
shakuzen
added
the
waiting for feedback
|
@shakuzen Thanks for letting me know! I rebased this on the |
jonatan-ivanov
added
type: task
|
Thanks! :) |
marcingrzejszczak
added a commit
that referenced
this pull request
Apr 12, 2022
This reverts commit 0c919bb.
marcingrzejszczak
added a commit
that referenced
this pull request
Apr 12, 2022
* Added compatibility plugin * Revert "Remove deprecated MissingRequiredConfigurationException and its usages (#2987)" This reverts commit fde4f3d. * Revert "Remove StatsdConfig.queueSize() (#568)" This reverts commit 0c919bb. * Revert "Remove deprecated methods in GangliaConfig" This reverts commit a8ebe88. * Revert "Remove deprecated ElasticConfig#documentType" This reverts commit dfab16a. * Revert "Remove deprecated constructor and dropwizard dependency" This reverts commit acb6d7f. * Revert "Remove deprecated method newLongTaskTimer(Id) on MeterRegistry" This reverts commit 852991d. * Revert "Remove Hibernate optional dependency" This reverts commit 575b85e. * Revert "Remove deprecated KafkaConsumerMetrics" This reverts commit 207bb38. * Revert "Remove deprecated JettyStatisticsMetrics" This reverts commit 0902d4a. * Revert "Remove deprecated Hibernate metrics" This reverts commit 31ad59f. * Revert "Remove deprecated DiskSpaceMetrics" This reverts commit 46c8d37. * Revert "Delete deprecated binders" This reverts commit f8a508d. * Revert "Deprecating core.instrument.binder and move classes to binder package (#3043)" This reverts commit 531cb87. * Revert "Remove things added back in merge by mistake." This reverts commit 4cc4c20. * Ensures binary compatibility * 1.10.x KeyValue & KeyValues (#3122) * Trying to fix the Tag & Tags confusion - we rename Tag & Tags into KeyValue and KeyValues - that way there will be no confusions between the current Tag(s) and the ones from the common module - TagKey will have the "of" method removed - that way we will not be returning Tags from commons that can be then used by micrometer's core code - Changed since from 2.0.0 to 1.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
StatsdConfig.queueSize()as it's not used since d1edf7d.