Downgrade okhttp to 4.11.0 upgrade Kotlin to 1.9 #4597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
added
type: task
Uses Kotlin 1.9 to compile but remains compatible with Kotlin 1.7. For this, we need to be on OkHttp 4.11.0. Upgrading to 4.12.0 makes Kotlin 1.7 not work in the sample.
shakuzen
force-pushed
the
downgrade-okhttp-upgrade-kotlin
branch
from
23e1c3d
to
2aaaa2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OkHttp 4.12.0 depends on a version of okio that ends up requiring Kotlin 1.9. We only have an optional dependency on OkHttp so we could upgrade to 4.12.0, but I would rather not compile against a newer version of OkHttp than our users can use if they are on our minimum supported version of Kotlin (1.7). For that reason, compiles against the latest version of OkHttp that is compatible with Kotlin 1.7 - OkHttp 4.11.0.
Uses Kotlin 1.9 to compile but remains compatible with Kotlin 1.7.