Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish MeterTag changes #3769

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Apr 16, 2023

This PR polishes the MeterTag changes changes a bit.

See gh-3727

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Apr 16, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/micrometer-metrics/micrometer/3769.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/micrometer-metrics/micrometer/3769.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

…on/AnnotationUtils.java

Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
@marcingrzejszczak marcingrzejszczak added the type: task A general task label Apr 18, 2023
@marcingrzejszczak marcingrzejszczak added this to the 1.11.0 milestone Apr 18, 2023
@marcingrzejszczak marcingrzejszczak merged commit 9b61c23 into micrometer-metrics:main Apr 18, 2023
@marcingrzejszczak
Copy link
Contributor

@izeye can you check if following this commit (micrometer-metrics/micrometer-docs@800a561 ) anything there needs to be changed?

izeye added a commit to izeye/micrometer-docs that referenced this pull request Apr 18, 2023
This commit polishes 800a561 to align with the changes made in micrometer-metrics/micrometer#3769.
@izeye
Copy link
Contributor Author

izeye commented Apr 18, 2023

@marcingrzejszczak Sure, I created micrometer-metrics/micrometer-docs#300.

@izeye izeye deleted the polish-gh-3727 branch April 18, 2023 12:29
izeye added a commit to izeye/micrometer-docs that referenced this pull request Apr 18, 2023
This commit polishes 800a561 to align with the changes made in micrometer-metrics/micrometer#3769.
marcingrzejszczak pushed a commit to micrometer-metrics/micrometer-docs that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants