Add Azure Application Insights connection string support

implementations/micrometer-registry-azure-monitor/src/main/java/io/micrometer/azuremonitor/AzureMonitorConfig.java

@@ -43,10 +43,19 @@ default String instrumentationKey() {
         return getSecret(this, "instrumentationKey").get();
     }
 
+    /**
+     * default implementation to get the connection string from the config
+     * @return Connection String
+     */
+    default String connectionString() {
+        return getSecret(this, "connectionString").get();
+    }
+
     @Override
     default Validated<?> validate() {
         return checkAll(this, c -> StepRegistryConfig.validate(c),
-                check("instrumentationKey", AzureMonitorConfig::instrumentationKey));
+                check("instrumentationKey", AzureMonitorConfig::instrumentationKey),
+                check("connectionString", AzureMonitorConfig::connectionString));
     }
 
 }

implementations/micrometer-registry-azure-monitor/src/main/java/io/micrometer/azuremonitor/AzureMonitorMeterRegistry.java

@@ -63,11 +63,18 @@ private AzureMonitorMeterRegistry(AzureMonitorConfig config, Clock clock,
         super(config, clock);
 
         config().namingConvention(new AzureMonitorNamingConvention());
+
         if (StringUtils.isEmpty(telemetryConfiguration.getInstrumentationKey())) {
             checkRequired("instrumentationKey", AzureMonitorConfig::instrumentationKey).apply(config).orThrow();
             telemetryConfiguration.setInstrumentationKey(config.instrumentationKey());
         }
 
+        // Connection string overrides instrumentation key when present
+        if (StringUtils.isEmpty(telemetryConfiguration.getConnectionString())) {
+            checkRequired("connectionString", AzureMonitorConfig::connectionString).apply(config).orThrow();
+            telemetryConfiguration.setConnectionString(config.connectionString());
+        }
+
         client = new TelemetryClient(telemetryConfiguration);
         client.getContext().getInternal().setSdkVersion(SDK_VERSION);
 

implementations/micrometer-registry-azure-monitor/src/main/java/io/micrometer/azuremonitor/AzureMonitorUtils.java

@@ -0,0 +1,35 @@
+/*
+ * Copyright 2018 VMware, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.micrometer.azuremonitor;
+
+import java.util.Arrays;
+import java.util.Objects;
+
+public final class AzureMonitorUtils {
+
+    public static String extractInstrumentationKeyFromConnectionString(final String connectionString) {
+        return Arrays.stream(connectionString.split(";"))
+            .filter(s -> Objects.equals("InstrumentationKey", s.split("=")[0]))
+            .map(s -> s.split("=")[1])
+            .findFirst()
+            .orElse("");
+    }
+
+    private AzureMonitorUtils() {
+        // Utility class
+    }
+
+}

implementations/micrometer-registry-azure-monitor/src/test/java/io/micrometer/azuremonitor/AzureMonitorConfigTest.java

@@ -31,6 +31,7 @@ class AzureMonitorConfigTest {
     @Test
     void valid() {
         props.put("azuremonitor.instrumentationKey", "secret");
+        props.put("azuremonitor.connectionString", "secret");
 
         assertThat(config.validate().isValid()).isTrue();
     }

implementations/micrometer-registry-azure-monitor/src/test/java/io/micrometer/azuremonitor/AzureMonitorMeterRegistryCompatibilityKit.java

@@ -29,6 +29,11 @@ public String instrumentationKey() {
             return "fakeKey";
         }
 
+        @Override
+        public String connectionString() {
+            return "InstrumentationKey=fakeKey";
+        }
+
         @Override
         public String get(String key) {
             return null;

implementations/micrometer-registry-azure-monitor/src/test/java/io/micrometer/azuremonitor/AzureMonitorMeterRegistryTest.java

@@ -47,6 +47,11 @@ public String get(String key) {
         public String instrumentationKey() {
             return "myInstrumentationKey";
         }
+
+        @Override
+        public String connectionString() {
+            return "InstrumentationKey=myInstrumentationKey";
+        }
     };
 
     private final MockClock clock = new MockClock();
@@ -56,9 +61,17 @@ public String instrumentationKey() {
     @Test
     void useTelemetryConfigInstrumentationKeyWhenSet() {
         TelemetryConfiguration telemetryConfiguration = TelemetryConfiguration.createDefault();
-        telemetryConfiguration.setInstrumentationKey("fake");
+        telemetryConfiguration.setInstrumentationKey("myInstrumentationKey");
+        AzureMonitorMeterRegistry.builder(config).telemetryConfiguration(telemetryConfiguration).build();
+        assertThat(telemetryConfiguration.getInstrumentationKey()).isEqualTo("myInstrumentationKey");
+    }
+
+    @Test
+    void useTelemetryConfigConnectionStringWhenSet() {
+        TelemetryConfiguration telemetryConfiguration = TelemetryConfiguration.createDefault();
+        telemetryConfiguration.setConnectionString("InstrumentationKey=myInstrumentationKey");
         AzureMonitorMeterRegistry.builder(config).telemetryConfiguration(telemetryConfiguration).build();
-        assertThat(telemetryConfiguration.getInstrumentationKey()).isEqualTo("fake");
+        assertThat(telemetryConfiguration.getConnectionString()).isEqualTo("InstrumentationKey=myInstrumentationKey");
     }
 
     @Test

implementations/micrometer-registry-azure-monitor/src/test/java/io/micrometer/azuremonitor/AzureMonitorUtilsTest.java

@@ -0,0 +1,70 @@
+/*
+ * Copyright 2018 VMware, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.micrometer.azuremonitor;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.UUID;
+
+import static io.micrometer.azuremonitor.AzureMonitorUtils.*;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+class AzureMonitorUtilsTest {
+
+    @Test
+    void testExtractInstrumentationKeyFromConnectionString() {
+        final String expectedInstrumentationKey = UUID.randomUUID().toString();
+
+        final String connectionString = String.format(
+                "InstrumentationKey=%s;IngestionEndpoint=https://westeurope-5.in.applicationinsights.azure.com/;LiveEndpoint=https://westeurope.livediagnostics.monitor.azure.com/",
+                expectedInstrumentationKey);
+
+        final String actualInstrumentationKey = extractInstrumentationKeyFromConnectionString(connectionString);
+
+        assertThat(actualInstrumentationKey).isEqualTo(expectedInstrumentationKey);
+    }
+
+    @Test
+    void testExtractInstrumentationKeyFromConnectionString_missing() {
+        final String expectedInstrumentationKey = "";
+
+        final String connectionString = "IngestionEndpoint=https://westeurope-5.in.applicationinsights.azure.com/;LiveEndpoint=https://westeurope.livediagnostics.monitor.azure.com/";
+
+        final String actualInstrumentationKey = extractInstrumentationKeyFromConnectionString(connectionString);
+
+        assertThat(actualInstrumentationKey).isEqualTo(expectedInstrumentationKey);
+    }
+
+    @Test
+    void testExtractInstrumentationKeyFromConnectionString_empty() {
+        final String expectedInstrumentationKey = "";
+
+        final String connectionString = "";
+
+        final String actualInstrumentationKey = extractInstrumentationKeyFromConnectionString(connectionString);
+
+        assertThat(actualInstrumentationKey).isEqualTo(expectedInstrumentationKey);
+    }
+
+    @Test
+    void testExtractInstrumentationKeyFromConnectionString_null() {
+        final String connectionString = null;
+
+        assertThrows(NullPointerException.class, () -> extractInstrumentationKeyFromConnectionString(connectionString));
+    }
+
+}

samples/micrometer-samples-boot2/src/main/java/io/micrometer/boot2/samples/AzureMonitorSample.java

@@ -33,7 +33,8 @@ public static void main(String[] args) {
 
     @Bean
     AzureMonitorMeterRegistry azureMonitorMeterRegistry(Environment environment) {
-        // will need an application property `azure.instrumentationKey` to be set
+        // will need an application property `azure.instrumentationKey` or
+        // `azure.connectionString` to be set
         return AzureMonitorMeterRegistry.builder(environment::getProperty).build();
     }
 

samples/micrometer-samples-core/src/main/java/io/micrometer/core/samples/utils/SampleRegistries.java

@@ -25,6 +25,7 @@
 import io.micrometer.atlas.AtlasMeterRegistry;
 import io.micrometer.azuremonitor.AzureMonitorConfig;
 import io.micrometer.azuremonitor.AzureMonitorMeterRegistry;
+import io.micrometer.azuremonitor.AzureMonitorUtils;
 import io.micrometer.common.lang.Nullable;
 import io.micrometer.core.instrument.Clock;
 import io.micrometer.core.instrument.MeterRegistry;
@@ -414,6 +415,35 @@ public String instrumentationKey() {
                 return apiKey;
             }
 
+            @Override
+            public String connectionString() {
+                return String.format("InstrumentationKey=%s", apiKey);
+            }
+
+            @Override
+            public String get(String key) {
+                return null;
+            }
+
+            @Override
+            public Duration step() {
+                return Duration.ofSeconds(10);
+            }
+        }, Clock.SYSTEM);
+    }
+
+    public static AzureMonitorMeterRegistry azureWithConnectionString(String connectionString) {
+        return new AzureMonitorMeterRegistry(new AzureMonitorConfig() {
+            @Override
+            public String instrumentationKey() {
+                return AzureMonitorUtils.extractInstrumentationKeyFromConnectionString(connectionString);
+            }
+
+            @Override
+            public String connectionString() {
+                return connectionString;
+            }
+
             @Override
             public String get(String key) {
                 return null;