Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish TestObservationRegistryAssert changes #3480

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Polish TestObservationRegistryAssert changes #3480

merged 1 commit into from
Oct 10, 2022

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Oct 8, 2022

This PR polishes TestObservationRegistryAssert changes a bit.

See gh-3432

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Oct 8, 2022

⚠️ 10 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@izeye izeye mentioned this pull request Oct 8, 2022
Merged
@izeye
Copy link
Contributor Author

izeye commented Oct 8, 2022

See #3481 for the build failures.

@shakuzen shakuzen added the polish A general improvement (naming things, fixing minor issues, etc.) label Oct 10, 2022
@shakuzen shakuzen added this to the 1.10.0-RC1 milestone Oct 10, 2022
@shakuzen shakuzen merged commit f8d8ab1 into micrometer-metrics:main Oct 10, 2022
@izeye izeye deleted the gh-3432 branch October 10, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
polish A general improvement (naming things, fixing minor issues, etc.)
Projects
None yet
Milestone
1.10.0-RC1
Development

Successfully merging this pull request may close these issues.
2 participants
@izeye @shakuzen