Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish relative to PushMeterRegistry initialization time and align StepMeter boundaries to that #3450

Closed
wants to merge 15 commits into from
Closed

Publish relative to PushMeterRegistry initialization time and align StepMeter boundaries to that #3450

wants to merge 15 commits into from

Commits on Nov 17, 2022

  1. Update: Publish at registry start time

    @shakuzen
    ljaganathan authored and shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    82dca79 View commit details
    Browse the repository at this point in the history

  2. Update: Publish at registry start time

    @shakuzen
    ljaganathan authored and shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    85dcfe0 View commit details
    Browse the repository at this point in the history

  3. Test timing of publish including on stop/start 

    The publishing should not happen relative to the epoch step with publishAtStep set to false. Rather it should happen relative to the meters' step, which is offset from the epoch steps by `registryStartMillis`.
    @shakuzen
    shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    4ae4969 View commit details
    Browse the repository at this point in the history

  4. Polish 

    Renames variables/methods with the intention to improve clarity and readability. Edits the description of the new config method JavaDoc.
    @shakuzen
    shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    3fbd2c3 View commit details
    Browse the repository at this point in the history

  5. Polish

    @shakuzen
    shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    fc258da View commit details
    Browse the repository at this point in the history

  6. Flip default to align publishing with registry instantiation 

    We know the previous behavior causes issues with many instances running, which makes it not a good default. We will leave this configuration for now so that users have a way to opt out of the new behavior if it causes unforeseen issues for them.
Adds a warning to the JavaDoc about the side effect of aligning to the Epoch.
    @shakuzen
    shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    49bbb41 View commit details
    Browse the repository at this point in the history

  7. Fix: failing signal-fx tests

    @shakuzen
    ljaganathan authored and shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    0027687 View commit details
    Browse the repository at this point in the history

  8. Update: [SignalFxMeterRegistry] Publish meters with step start millis

    @lenin-jaganathan @shakuzen
    lenin-jaganathan authored and shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    fb734a2 View commit details
    Browse the repository at this point in the history

  9. Rework test for delay to push 

    The previous test was flaky and relied on system-clock timings. This is replaced with a more direct test of calculating the delay by extracting the logic to a package-private method.
    @shakuzen
    shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    cc0df1e View commit details
    Browse the repository at this point in the history

  10. Polish

    @shakuzen
    shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    0bceaba View commit details
    Browse the repository at this point in the history

  11. Revert change to SignalFx timestamp 

    We can consider such a change separate from this changeset.
    @shakuzen
    shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    b1470a8 View commit details
    Browse the repository at this point in the history

  12. Update SignalFx tests 

    Record in the middle of the step to avoid histogram counts being rotated out by the time of the simulated publication in the affected tests.
    @shakuzen
    shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    9835785 View commit details
    Browse the repository at this point in the history

  13. Polish naming and JavaDocs 

    This updates names to hopefully make more clear their usage, while also polishing the JavaDocs to give more background.
    @shakuzen
    shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    147f183 View commit details
    Browse the repository at this point in the history

  14. Polish JavaDoc

    @shakuzen
    shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    3752129 View commit details
    Browse the repository at this point in the history

  15. Fix config reference in test

    @shakuzen
    shakuzen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    530b665 View commit details
    Browse the repository at this point in the history