DefaultLongTaskTimer histogram bucket counting logic fix
#2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The histogram was not correct in all cases before. The added test demonstrates a case that would fail with the previous logic. Buckets that should have been zero were not.
shakuzen
added
bug
|
Note: this is a separate issue from #2744. I have another test locally for that issue and will work on a fix for it separate from this change. |
micrometer-core/src/main/java/io/micrometer/core/instrument/internal/DefaultLongTaskTimer.java
Outdated
Show resolved
Hide resolved
We don't want to compare the current bucket to the current duration where the duration is potentially different on each iteration. We get all the durations first and then iterate, which is closer to the expected behavior of a true snapshot.
It's testing logic in the DefaultLongTaskTimer class, so it is more appropriate for it to be in that test class.
jonatan-ivanov
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The histogram was not correct in all cases before. The added test demonstrates a case that would fail with the previous logic. Buckets that should have been zero were not.
I came across this while looking into another bug with LongTaskTimer histograms: #2744