Upgrade to Reactor 3.4 and Reactor Netty 1.0 #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
commented
Nov 24, 2020
| @@ -66,7 +66,7 @@ void bufferMultipleStrings() { | |||
| "fourteen bytes" | |||
| ); | |||
|
|
|||
| Flux<String> buffered = BufferingFlux.create(source, "\n", 27, Long.MAX_VALUE); | |||
| Flux<String> buffered = BufferingFlux.create(source, "\n", 27, 1000); | |||
There was a problem hiding this comment.
Passing Long.MAX_VALUE here causes an overflow (since Reactor 3.4) because Long.MAX_VALUE milliseconds eventually tries to get converted to nanoseconds.
simonbasle
suggested changes
Nov 24, 2020
...ry-statsd/src/main/java/io/micrometer/statsd/internal/LogbackMetricsSuppressingManySink.java
Outdated
Show resolved
Hide resolved
...s/micrometer-registry-statsd/src/test/java/io/micrometer/statsd/StatsdMeterRegistryTest.java
Outdated
Show resolved
Hide resolved
...s/micrometer-registry-statsd/src/test/java/io/micrometer/statsd/StatsdMeterRegistryTest.java
Outdated
Show resolved
Hide resolved
This also switches to using the Reactor BOM for dependency management. Some internal changes to the StatsD registry usage of Reactor were necessary with the move from Processors to Sinks. The many, multicast, directBestEffort Sink is the closest match to DirectProcessor that we were using before. With 1.0, reactor-netty now offers a core dependency that doesn't include HTTP, which we can use to save some bytes in the statsd JAR. Resolves micrometer-metricsgh-2319
simonbasle
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also switches to using the Reactor BOM for dependency management. Some internal changes to the StatsD registry usage of Reactor were necessary with the move from Processors to Sinks. The many, multicast, directBestEffort Sink is the closest match to DirectProcessor that we were using before.
With 1.0, reactor-netty now offers a core dependency that doesn't include HTTP, which we can use to save some bytes in the statsd JAR.
Resolves gh-2319