Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double for values in Elasticsearch meter registry #1421

Merged
merged 1 commit into from
May 15, 2019

Conversation

izeye
Copy link
Contributor

@izeye izeye commented May 14, 2019

This PR changes to use double for values in Elasticsearch meter registry.

Closes gh-1071
Closes gh-1420

@izeye
Copy link
Contributor Author

izeye commented May 14, 2019

There's a caveat. If the metrics_template template already exists, it needs to be deleted first before running. Another name could be chosen but the old one should be cleaned up anyway.

@shakuzen shakuzen added the release notes Noteworthy change to call out in the release notes label May 15, 2019
@shakuzen
Copy link
Member

There's a caveat. If the metrics_template template already exists, it needs to be deleted first before running. Another name could be chosen but the old one should be cleaned up anyway.

I've tagged this with release notes so it can be mentioned in the release notes. Thank you for pointing it out.

@shakuzen shakuzen added the registry: elastic An ElasticSearch Registry related issue label May 15, 2019
@shakuzen shakuzen added this to the 1.1.5 milestone May 15, 2019
@shakuzen shakuzen merged commit 0caad97 into micrometer-metrics:1.1.x May 15, 2019
@izeye izeye deleted the gh-1071 branch May 15, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
registry: elastic An ElasticSearch Registry related issue release notes Noteworthy change to call out in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants