Log a warning when instrumenting a cache that is not recording stats #5066
Labels
enhancement
A general enhancement
help wanted
An issue that a contributor can help us with
instrumentation
An issue that is related to instrumenting a component
module: micrometer-core
An issue that is related to our core module
Milestone
Comments
shakuzen
added
enhancement
|
That sounds like a good improvement to me. Would you or anyone else be interested in making a pull request for it? |
izeye
added a commit
to izeye/micrometer
that referenced
this issue
Aug 25, 2024
…in CaffeineCacheMetrics See micrometer-metricsgh-5066
|
I created #5402 to try to resolve this for the |
izeye
added a commit
to izeye/micrometer
that referenced
this issue
Aug 28, 2024
…in CaffeineCacheMetrics See micrometer-metricsgh-5066
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please describe the feature request.
It would be nice if a warning were logged (or the user was informed in some way) when a cache is instrumented that is not recording stats.
Rationale
For some Cache implementations like Caffeine recording stats is optional. When instrumenting a cache that is not recording stats the meters will constantly report 0 which could be misleading. This is probably not what the user desires.
Additional context
apache/accumulo#4552
The text was updated successfully, but these errors were encountered: