-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistently add outcome
tag to all HTTP client instrumentation
#3729
Comments
Thanks for opening the issue. Which HTTP client instrumentation are you using? We already have an outcome tag on some of them. |
Thank you for the swift answer. I was instrumenting JDK11 I'll happily raise a couple of PRs for different clients to align it |
Thank you for the offer to help. We'd be happy to review pull requests for this. |
outcome
tag to HTTP client instrumentation
outcome
tag to HTTP client instrumentationoutcome
tag to all HTTP client instrumentation
To enhance metrics filtering, a grouping
outcome
tag would be helpful inhttp_client_requests
, similar to theoutcome
tag in thehttp_server_requests
.For less matured metrics systems (like CloudWatch) it's impossible to filter by patterns, and having a similar grouping in HTTP client and server metrics would be very helpful.
PS. I couldn't find any issue related to this one, so I created a new one. Please let me know if I've overlooked something
PS2. If such a tag makes sense, I'm happy to raise a PR and work on that.
The text was updated successfully, but these errors were encountered: