Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Nullable annotation imported #2779

Closed
shakuzen opened this issue Sep 15, 2021 · 0 comments
Closed

Wrong Nullable annotation imported #2779

shakuzen opened this issue Sep 15, 2021 · 0 comments
Labels
bug A general bug registry: appoptics An AppOptics Registry related issue
Milestone
1.6.11

Comments

@shakuzen
Copy link
Member

We should use our @Nullable annotation.

micrometer/implementations/micrometer-registry-appoptics/src/main/java/io/micrometer/appoptics/AppOpticsMeterRegistry.java

Line 29 in 0fdedb4

import javax.annotation.Nullable;

@shakuzen shakuzen added bug A general bug registry: appoptics An AppOptics Registry related issue labels Sep 15, 2021
@shakuzen shakuzen added this to the 1.6.11 milestone Sep 15, 2021
izeye added a commit to izeye/micrometer that referenced this issue Nov 8, 2021
@izeye
Add javax.annotation.Nullable to IllegalImportCheck
d0fe982 
This commit also splits IllegalImportCheck into GeneralIllegalImportCheck and SLF4JIllegalImportCheck as the suppression on implementations should be limited to the SLF4J only.

See micrometer-metricsgh-2779
@izeye izeye mentioned this issue Nov 8, 2021
Merged
shakuzen pushed a commit that referenced this issue Nov 8, 2021
@izeye
Add javax.annotation.Nullable to IllegalImportCheck (#2850)
9624b8a 
This commit also splits IllegalImportCheck into GeneralIllegalImportCheck and SLF4JIllegalImportCheck as the suppression on implementations should be limited to the SLF4J only.

See gh-2779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A general bug registry: appoptics An AppOptics Registry related issue
Projects
None yet
Milestone
1.6.11
Development

No branches or pull requests
1 participant
@shakuzen