Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElasticMeterRegistry should allow indexType override #1891

Closed
magaton opened this issue Mar 9, 2020 · 2 comments · Fixed by #1892
Closed

ElasticMeterRegistry should allow indexType override #1891

magaton opened this issue Mar 9, 2020 · 2 comments · Fixed by #1892
Labels
enhancement A general enhancement registry: elastic An ElasticSearch Registry related issue
Milestone

Comments

@magaton
Copy link
Contributor

magaton commented Mar 9, 2020

Currently, for ES versions < 7, indexType is hardcoded in TYPE_PATH_BEFORE_VERSION_7 static variable.
It would be good to have a way to override the indexType, so it can be something other than 'doc'

magaton pushed a commit to magaton/micrometer that referenced this issue Mar 9, 2020
@shakuzen shakuzen added enhancement A general enhancement registry: elastic An ElasticSearch Registry related issue labels Mar 10, 2020
@shakuzen shakuzen added this to the 1.4.0 milestone Mar 10, 2020
@shakuzen
Copy link
Member

shakuzen commented Mar 10, 2020

As a note for future planning, once we no longer support Elasticsearch versions less than 7, we should remove this configuration option.

Based on Elasticsearch's published EOL schedule, it looks like that will be sometime around the end of this year: https://www.elastic.co/support/eol

Elasticsearch EOL date Maintained until
6.8.x 2020-11-20 8.0.0

@shakuzen
Copy link
Member

I think we made a mistake when we made this a method on ElasticMeterRegistry instead of a method in ElasticConfig and use that in ElasticMeterRegistry. I'd like to change that before releasing 1.4, so I am reopening this. In fact, we had a change for that already (#1328) that I missed when reviewing this issue and corresponding pull request.

@shakuzen shakuzen reopened this Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement registry: elastic An ElasticSearch Registry related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants