Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove xss #252

Merged
merged 1 commit into from
Dec 30, 2019
Merged

feat: remove xss #252

merged 1 commit into from
Dec 30, 2019

Conversation

Kikobeats
Copy link
Member

@Kikobeats Kikobeats commented Dec 30, 2019

Reason for removing xss:

  • core simplification. You can always do that after metascraper get the data, as part of your workflow and your use case.
  • Some packages have been designed specifically to output HTML (like metascraper-iframe).
  • xss is assuming data is going to be exposed publicly under an HTTP server (and that's not).

closes #251

@coveralls
Copy link
Collaborator

Coverage Status

Coverage increased (+0.9%) to 97.222% when pulling e26ad24 on xss into ddd373b on master.

@Kikobeats Kikobeats merged commit 87670c1 into master Dec 30, 2019
@Kikobeats Kikobeats deleted the xss branch December 30, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iframe metadata should not be escaped
2 participants