Skip to content

Commit

Permalink
test: remove uses of common.PORT in test-tls-client tests
Browse files Browse the repository at this point in the history
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: nodejs/node#12461
Ref: nodejs/node#12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
  • Loading branch information
z0al authored and andrew749 committed Jul 19, 2017
1 parent 02ac410 commit ad702a8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions test/parallel/test-tls-client-abort.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ const path = require('path');
const cert = fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'));
const key = fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem'));

const conn = tls.connect({cert: cert, key: key, port: common.PORT}, function() {
assert.ok(false); // callback should never be executed
});
const conn = tls.connect({cert, key, port: 0}, common.mustNotCall());
conn.on('error', function() {
});
assert.doesNotThrow(function() {
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-tls-client-abort2.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ if (!common.hasCrypto) {
}
const tls = require('tls');

const conn = tls.connect(common.PORT, common.mustNotCall());
const conn = tls.connect(0, common.mustNotCall());
conn.on('error', common.mustCall(function() {
assert.doesNotThrow(function() {
conn.destroy();
Expand Down

0 comments on commit ad702a8

Please sign in to comment.