Skip to content

Commit

Permalink
test: cleanup test-fs-watch.js
Browse files Browse the repository at this point in the history
Reversed "actual" and "expected" arguments for assert.strictEqual().

Replaced constructor with regular expression for assert.throws().

PR-URL: nodejs/node#12595
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
  • Loading branch information
RobotMermaid authored and andrew749 committed Jul 19, 2017
1 parent d7402d6 commit 9e3ccf5
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions test/sequential/test-fs-watch.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ assert.doesNotThrow(
function() {
const watcher = fs.watch(filepathOne);
watcher.on('change', function(event, filename) {
assert.strictEqual('change', event);
assert.strictEqual(event, 'change');

if (expectFilePath) {
assert.strictEqual('watch.txt', filename);
assert.strictEqual(filename, 'watch.txt');
}
watcher.close();
++watchSeenOne;
Expand All @@ -58,10 +58,10 @@ fs.writeFileSync(filepathTwoAbs, 'howdy');
assert.doesNotThrow(
function() {
const watcher = fs.watch(filepathTwo, function(event, filename) {
assert.strictEqual('change', event);
assert.strictEqual(event, 'change');

if (expectFilePath) {
assert.strictEqual('hasOwnProperty', filename);
assert.strictEqual(filename, 'hasOwnProperty');
}
watcher.close();
++watchSeenTwo;
Expand All @@ -83,9 +83,9 @@ assert.doesNotThrow(
const renameEv = common.isSunOS ? 'change' : 'rename';
assert.strictEqual(renameEv, event);
if (expectFilePath) {
assert.strictEqual('newfile.txt', filename);
assert.strictEqual(filename, 'newfile.txt');
} else {
assert.strictEqual(null, filename);
assert.strictEqual(filename, null);
}
watcher.close();
++watchSeenThree;
Expand All @@ -112,13 +112,13 @@ assert.throws(function() {
oldhandle = w._handle;
w._handle = { close: w._handle.close };
w.close();
}, TypeError);
}, /^TypeError: Illegal invocation$/);
oldhandle.close(); // clean up

assert.throws(function() {
const w = fs.watchFile(__filename, {persistent: false}, function() {});
oldhandle = w._handle;
w._handle = { stop: w._handle.stop };
w.stop();
}, TypeError);
}, /^TypeError: Illegal invocation$/);
oldhandle.stop(); // clean up

0 comments on commit 9e3ccf5

Please sign in to comment.