Prepare for Sidekiq v7 #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems they are replacing all usage of worker with job. Let's do the same in this repo to stay consistent with newer Sidekiq.
adamcreekroad
added a commit
to adamcreekroad/sidekiq-unique-jobs
that referenced
this pull request
Oct 26, 2022
BACKGROUND ------------------------------------------------------------- mhenrixon#707 introduced a regression where the instance level `after_unlock` callback is no longer being called. This was due to the change of using `item[CLASS]` instead of `worker_class` to set `job_class` in `SidekiqUniqueJobs::Middelware#call`. `item[CLASS]` is a string, where as `worker_class` can be either an instance, or the class itself. For the instance level `after_unlock` to work, we need `job_class` to be an instance of the worker. This fixes the issue by switching back to setting `job_class` to `worker_class` CHANGELOG -------------------------------------------------------------- - User worker_class for self.job_class in Middleware#call
adamcreekroad
added a commit
to adamcreekroad/sidekiq-unique-jobs
that referenced
this pull request
Oct 26, 2022
BACKGROUND ------------------------------------------------------------- mhenrixon#707 introduced a regression where the instance level `after_unlock` callback is no longer being called. This was due to the change of using `item[CLASS]` instead of `worker_class` to set `job_class` in `SidekiqUniqueJobs::Middelware#call`. `item[CLASS]` is a string, where as `worker_class` can be either an instance, or the class itself. For the instance level `after_unlock` to work, we need `job_class` to be an instance of the worker. This fixes the issue by switching back to setting `job_class` to `worker_class` CHANGELOG -------------------------------------------------------------- - Use worker_class for self.job_class in Middleware#call
adamcreekroad
added a commit
to adamcreekroad/sidekiq-unique-jobs
that referenced
this pull request
Oct 27, 2022
BACKGROUND ------------------------------------------------------------- mhenrixon#707 introduced a regression where the instance level `after_unlock` callback is no longer being called. This was due to the change of using `item[CLASS]` instead of `worker_class` to set `job_class` in `SidekiqUniqueJobs::Middelware#call`. `item[CLASS]` is a string, where as `worker_class` can be either an instance, or the class itself. For the instance level `after_unlock` to work, we need `job_class` to be an instance of the worker. This fixes the issue by switching back to setting `job_class` to `worker_class` CHANGELOG -------------------------------------------------------------- - Use worker_class for self.job_class in Middleware#call
mhenrixon
added a commit
that referenced
this pull request
Dec 3, 2022
BACKGROUND ------------------------------------------------------------- #707 introduced a regression where the instance level `after_unlock` callback is no longer being called. This was due to the change of using `item[CLASS]` instead of `worker_class` to set `job_class` in `SidekiqUniqueJobs::Middelware#call`. `item[CLASS]` is a string, where as `worker_class` can be either an instance, or the class itself. For the instance level `after_unlock` to work, we need `job_class` to be an instance of the worker. This fixes the issue by switching back to setting `job_class` to `worker_class` CHANGELOG -------------------------------------------------------------- - Use worker_class for self.job_class in Middleware#call Co-authored-by: Mikael Henriksson <mikael@mhenrixon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems they are replacing all usage of workers with jobs. Let's do the same in this repo to stay consistent with the newer Sidekiq.
Closes #705