Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix canonical headers including or not including specific config… #158

Closed
wants to merge 1 commit into from
Closed

fix: Fix canonical headers including or not including specific config… #158

wants to merge 1 commit into from

Conversation

Hobart2967
Copy link

@Hobart2967 Hobart2967 commented Oct 2, 2023 •
edited
Loading

Fixes: #157

@Hobart2967 Hobart2967 mentioned this pull request Oct 2, 2023
Closed
@ryanblock
Copy link
Contributor

@Hobart2967 seems like a solid fix – any particular reason this PR does not currently include tests?

@Hobart2967
Copy link
Author

Hobart2967 commented Nov 23, 2023 •
edited
Loading

No, tbh, not really. Can include them as soon as I have some spare time. Didnt write them because I didnt See there we're some. Im used to have Test Files next to the actual Implementation, and overlooked the test folder while fixing.

@mxxk mxxk mentioned this pull request Jul 25, 2024
Closed
@mxxk
Copy link
Contributor

mxxk commented Aug 5, 2024

#168 includes the same logical changes as this PR, and also adds new tests (as requested). @mhart @ryanblock would you please take a look?

mhart added a commit that referenced this pull request Aug 6, 2024
@mhart
Ensure canonicalHeaders respects extraHeadersToInclude/Ignore
658294c 
Fixes #157 #158 #168

We introduce an extra function here, filterHeaders, and a cached value filteredHeaders similar to parsedPath.

Code isn't exactly as I'd write it using modern JS, but this fits in with the current style and ensures we don't accidentally use any newer JS APIs.
@mhart
Copy link
Owner

mhart commented Aug 6, 2024

Awesome, thanks for this and apologies for taking so long – I included this in v1.13.1

@mhart mhart closed this Aug 6, 2024
@ryanblock
Copy link
Contributor

Thanks, @mhart! 👏🏼👏🏼👏🏼

@LLotme LLotme mentioned this pull request Aug 27, 2024
Merged
@AKJUS AKJUS mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Headers to exclude are not excluded from the cannonicalHeaders
4 participants
@Hobart2967 @ryanblock @mxxk @mhart