-
Notifications
You must be signed in to change notification settings - Fork 51
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace "template variables" with "template_variables" (#2783)
Replace "template variables" with "template_variables" before searching for check rules with the rose mini-language. Replacing the "template variables" string after the search.
- Loading branch information
Showing
4 changed files
with
201 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| # Copyright (C) British Crown (Met Office) & Contributors. | ||
| # This file is part of Rose, a framework for meteorological suites. | ||
| # | ||
| # Rose is free software: you can redistribute it and/or modify | ||
| # it under the terms of the GNU General Public License as published by | ||
| # the Free Software Foundation, either version 3 of the License, or | ||
| # (at your option) any later version. | ||
| # | ||
| # Rose is distributed in the hope that it will be useful, | ||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| # GNU General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU General Public License | ||
| # along with Rose. If not, see <http://www.gnu.org/licenses/>. | ||
| # ----------------------------------------------------------------------------- | ||
|
|
||
| """Tests for rose macros rule module. | ||
| """ | ||
|
|
||
| import pytest | ||
| from metomi.rose.macros.rule import RuleEvaluator | ||
|
|
||
|
|
||
| param = pytest.param | ||
| rule_evaluator = RuleEvaluator() | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| 'section', | ||
| (('template variables'), ('namelist'), ('empy:suite.rc'))) | ||
| @pytest.mark.parametrize( | ||
| 'rule_in, id_in, rule_out, this, this_out', [ | ||
| param( | ||
| '{section}=FOO == 42', | ||
| '{section}=FOO', | ||
| '{% if this == 42 %}True{% else %}False{% endif %}', | ||
| '42', | ||
| {'this': '42'}, | ||
| id='basic_rule' | ||
| ), | ||
| param( | ||
| 'all({section}=FOO == "42")', | ||
| '{section}=FOO', | ||
| '{% if (this == _value0 and this == _value0 and' | ||
| ' this == _value0) %}True{% else %}False{% endif %}', | ||
| '42,43,44', | ||
| {'this': '42,43,44', '_value0': '42'}, | ||
| id='all_rule' | ||
| ), | ||
| param( | ||
| 'len({section}=FOO) < 4', | ||
| '{section}=FOO', | ||
| '{% if 3 < 4 %}True{% else %}False{% endif %}', | ||
| '42,43,44', | ||
| {'this': '42,43,44'}, | ||
| id='len_rule' | ||
| ) | ||
| ] | ||
| ) | ||
| def test__process_rule(rule_in, id_in, rule_out, this, this_out, section): | ||
| """Test processing of rules into jinja2. | ||
| Also provides tests for | ||
| https://github.com/metomi/rose/issues/2737 | ||
| """ | ||
| rule_in = rule_in.format(section=section) | ||
| id_in = id_in.format(section=section) | ||
| rule_evaluator._get_value_from_id = lambda *_: this | ||
| rule, map_ = rule_evaluator._process_rule( | ||
| rule_in, id_in, 'patchme', 'patchme') | ||
| assert rule == rule_out | ||
| assert map_ == this_out | ||
|
|
||
|
|
||
| def test__process_rule_scientific_numbers(): | ||
| """A string which looks like a scientific number comes out as | ||
| a scientific number. | ||
| """ | ||
| this = "99" | ||
| rule = 'template variables=FOO=="9e9"' | ||
|
|
||
| rule_evaluator._get_value_from_id = lambda *_: this | ||
|
|
||
| _, map_ = rule_evaluator._process_rule( | ||
| rule, 'template variables=FOO', 'patchme', 'patchme') | ||
| assert map_ == { | ||
| 'this': '99', | ||
| '_scinum0': 9000000000.0, | ||
| '_value0': '_scinum0' | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| #!/usr/bin/env bash | ||
| #------------------------------------------------------------------------------- | ||
| # Copyright (C) British Crown (Met Office) & Contributors. | ||
| # | ||
| # This file is part of Rose, a framework for meteorological suites. | ||
| # | ||
| # Rose is free software: you can redistribute it and/or modify | ||
| # it under the terms of the GNU General Public License as published by | ||
| # the Free Software Foundation, either version 3 of the License, or | ||
| # (at your option) any later version. | ||
| # | ||
| # Rose is distributed in the hope that it will be useful, | ||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| # GNU General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU General Public License | ||
| # along with Rose. If not, see <http://www.gnu.org/licenses/>. | ||
| #------------------------------------------------------------------------------- | ||
| # Test "rose metadata-check": | ||
| # Check that hack allowing section name [template variables] works. | ||
| # Follows example in https://github.com/metomi/rose/issues/2737 | ||
|
|
||
| . $(dirname $0)/test_header | ||
|
|
||
| CHECKS=( | ||
| "basic@template variables=FOO == 2" | ||
| # Check we don't need to deal with loop: Number-like-strings into numbers. | ||
| "num string@template variables=FOO == \"2e1\"" | ||
| # Check we don't need to deal with loop: Strings into proper string variables. | ||
| "str@template variables=FOO == \"Sir Topham Hat\"" | ||
| "amy@any(template variables=FOO == 2)" | ||
| "len@len(template variables=FOO) > 42" | ||
| "in list@template variables=FOO in [3, 4, 8]" | ||
| "combined@len(template variables=FOO) > 42 and any(template variables=FOO == 2)" | ||
| ) | ||
|
|
||
|
|
||
| # 3 tests for each case: | ||
| tests $(( ${#CHECKS[@]} * 5 )) | ||
|
|
||
| setup | ||
|
|
||
| mkdir -p ../meta | ||
|
|
||
| # Allows array members to have spaces without splitting: | ||
| for ((i = 0; i < ${#CHECKS[@]}; i++)); do | ||
| ID=$(echo "${CHECKS[$i]}" | awk -F '@' '{print $1}') | ||
| CHECK_=$(echo "${CHECKS[$i]}" | awk -F '@' '{print $2}') | ||
|
|
||
| TEST_KEY="$TEST_KEY_BASE::${ID}" | ||
| cat > ../meta/rose-meta.conf <<__META_CONFIG__ | ||
| [template variables=FOO] | ||
| fail-if=${CHECK_} | ||
| trigger=template variables=BAR: this == 1; | ||
| [template variables=BAR] | ||
| __META_CONFIG__ | ||
|
|
||
| cat > ../rose-app.conf <<__ICI__ | ||
| [template variables] | ||
| FOO=1 | ||
| !BAR=22 | ||
| __ICI__ | ||
|
|
||
| run_pass "$TEST_KEY" rose metadata-check -C ../meta | ||
| file_cmp "$TEST_KEY.out" "$TEST_KEY.out" </dev/null | ||
| file_cmp "$TEST_KEY.err" "$TEST_KEY.err" </dev/null | ||
| # Also covers upgrade macros, because these subclass | ||
| # --transform macros: | ||
| run_pass \ | ||
| "$TEST_KEY.macro --transform" \ | ||
| rose macro --transform -y -C ../ | ||
| run_pass \ | ||
| "$TEST_KEY.macro --validate" \ | ||
| rose macro --validate -C ../ | ||
|
|
||
| done | ||
|
|
||
| teardown |