Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too large index value does not cause an exception in RecordBuilder#setSystemChar() #283

Closed
cboehme opened this issue May 25, 2018 · 0 comments
Closed

Too large index value does not cause an exception in RecordBuilder#setSystemChar() #283

cboehme opened this issue May 25, 2018 · 0 comments
Labels
Bug

Comments

@cboehme
Copy link
Member

cboehme commented May 25, 2018

Calling RecordBuilder.setSystemChar(3, '1') should raise an IllegalArgumentException since ISO2709 supports only three system chars.
@cboehme cboehme added the Bug label May 25, 2018
cboehme added a commit that referenced this issue Dec 19, 2018
@cboehme
Fix parameter check in RecordBuilder#setSystemChar()
b26fd24 
The parameter check did not fail on indix values greater than 2 which
exceeds the space for system chars in Marc 21 records.

Fixes #283

(cherry picked from commit f96ef28)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cboehme