Add ability to specify --dependency style deps #105
Conversation
| const barSource = path.join(ROOT_DIR, 'examples/bar.ts'); | ||
| const barDest = path.join(ROOT_DIR, 'output/bar.ts'); | ||
| // Copy the dependency to the output directory | ||
| await exec(`cp "${barSource}" "${barDest}"`); |
There was a problem hiding this comment.
Unless there's something I'm not seeing, won't this mostly fail on Windows?
There was a problem hiding this comment.
Does cp not work on Windows? I used double quotes " specifically so that Windows wouldn't complain...
There was a problem hiding this comment.
I use bash on windows, that's why it worked for me. Otherwise, you need to use copy.
There was a problem hiding this comment.
You can use copyfiles to have it work mostly everywhere, or just rewrite the test to not need copying.
| { | ||
| // Create the parser | ||
| const { stdout, stderr } = await exec( | ||
| `npx peggy --plugin "${PLUGIN_PATH}" --dependency foo:./bar -o "${outTsName}" "${GRAMMAR_FILE}"` |
There was a problem hiding this comment.
It's worth trying with --dependencies "{\"foo\": \"./bar\"}" or a config file with a dependencies key, as well.
There was a problem hiding this comment.
I think this is okay, since Peggy merges --dependency and --dependencies together for us, we'll trust Peggy to do it right.
Fixes #100 and adds a test to make sure dependencies work in the future.