Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Peg$ prefix for types instead of I #75

Closed
ghost opened this issue Dec 30, 2021 · 4 comments
Closed

Use Peg$ prefix for types instead of I #75

ghost opened this issue Dec 30, 2021 · 4 comments

Comments

@ghost
Copy link

ghost commented Dec 30, 2021

Fwik the TypeScript community now sees the I prefix as an antipattern and is moving away from it.
microsoft/TypeScript-Handbook#121
I would suggest Peg$ prefix for some similarity to the original PEG.js JavaScript output!

@pjmolina pjmolina self-assigned this Mar 17, 2022
@pjmolina
Copy link
Contributor

I see your point about style conventions.
However change it now would make a breaking change for its current users.
I will postpone such change when doing a major refactor (grouped with other breaking changes).

@ghost
Copy link
Author

ghost commented Mar 17, 2022

Okay, thanks for clarifying.. best to not make a PR until a major refactor is done :)

@iccicci
Copy link
Contributor

iccicci commented Aug 12, 2022

What about an option which defaults to "I"?
That would give a way to solve the problem without being a breaking change.

@pjmolina
Copy link
Contributor

pjmolina commented Jan 2, 2023

Removed prefix on v. 3.0.0 with breaking change. Decided to do it this way to keep it as simple as possible.

@pjmolina pjmolina closed this as completed Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants