feat: Add K8s API communication check on startup #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesmithgh
force-pushed
the
k8s-api-healthcheck
branch
from
8bb10f5
to
d3c64e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 49.80% 49.80%
=======================================
Files 54 54
Lines 4883 4905 +22
=======================================
+ Hits 2432 2443 +11
- Misses 2202 2212 +10
- Partials 249 250 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mikesmithgh
force-pushed
the
k8s-api-healthcheck
branch
from
d3c64e9
to
738b865
Compare
mikesmithgh
changed the title
Signed-off-by: Mike Smith <10135646+mjsmith1028@users.noreply.github.com>
mikesmithgh
force-pushed
the
k8s-api-healthcheck
branch
from
d74d0ea
to
f6205b8
Compare
AmitKumarDas
reviewed
Jan 6, 2022
AmitKumarDas
reviewed
Jan 6, 2022
AmitKumarDas
reviewed
Jan 6, 2022
AmitKumarDas
reviewed
Jan 6, 2022
Signed-off-by: Mike Smith <10135646+mjsmith1028@users.noreply.github.com>
grzesuav
approved these changes
Jan 9, 2022
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to avoid container restarts on startup when metacontroller is in a service mesh (istio, kuma, etc). If the service mesh sidecar takes longer to come up than metacontroller, then metacontroller will have container restarts. The K8s API healthcheck lets us know that the sidecar is properly communicating and the API server is healthy.