Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REMOVE_* commands enhancements #2141

Merged
merged 8 commits into from
Sep 7, 2022
Merged

REMOVE_* commands enhancements #2141

merged 8 commits into from
Sep 7, 2022

Conversation

skelly37
Copy link
Contributor

@skelly37 skelly37 commented Sep 4, 2022 •
edited
Loading

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:
    Another batch of useful commands + patch to keep it strictly related to the removal procedure.

Problem

The commands were left to do later but seemed useful to us

  • JIRA ticket (optional): None

Solution

  1. Added commands to remove empty clusters and albums & to remove unclustered files
  2. Started using Tagger's removal methods to fix unexpected behavior I have encountered during development

Action

May be squashed imo

@rdswift
Copy link
Collaborator

rdswift commented Sep 4, 2022

I suspect that the comments on lines 246-247 can be removed?

@skelly37
Copy link
Contributor Author

skelly37 commented Sep 5, 2022

Ping @phw @zas, fully done imo

zas
zas requested changes Sep 5, 2022
View reviewed changes
picard/tagger.py Outdated Show resolved Hide resolved
@skelly37 skelly37 requested a review from zas September 5, 2022 20:26
zas
zas requested changes Sep 6, 2022
View reviewed changes
picard/tagger.py Outdated Show resolved Hide resolved
@skelly37 skelly37 requested a review from zas September 6, 2022 15:05
zas
zas previously approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zas zas requested a review from phw September 6, 2022 15:18
@skelly37 skelly37 requested review from zas and removed request for phw September 6, 2022 20:15
@zas zas requested a review from phw September 7, 2022 06:04
zas
zas approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit cbe4bbb into metabrainz:master Sep 7, 2022
@skelly37 skelly37 deleted the removing-commands branch September 7, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phw phw phw approved these changes

@zas zas zas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skelly37 @rdswift @phw @zas