Error handling #24
Merged
Error handling #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spk
force-pushed
the
tests-expect
branch
2 times, most recently
from
271052a
to
f7314be
Compare
|
Rebase needed. |
messense
reviewed
Mar 7, 2020
src/model/errors.rs
Outdated
| use std::fmt; | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct RobotparserError { |
There was a problem hiding this comment.
I'd call it Error, and it needs to implement std::error::Error
There was a problem hiding this comment.
I've implemented first but I saw that the Error description is deprecated cf rust-lang/rust#66919 do you think we should still implement it ?
There was a problem hiding this comment.
I think you can just add a blank impl for it
There was a problem hiding this comment.
Ok thanks its done in b2525b5
messense
reviewed
Mar 7, 2020
messense
approved these changes
Mar 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this add initial error management let me know what you think, cheers