exchanger: Fix Recurse logic #302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a logic bug introduced with the refactoring of the external resolver code: 31f5539 The bug manifested when external queries would be sent to configured resolvers that would reply with non-authoritative answers. These answers weren't considered valid and if the message would contain an SOA record in its authoritative section then it would be erroneously recursed.
|
Ref: #301 |
| func Recurse(r *dns.Msg) string { | ||
| if r.Authoritative && len(r.Answer) > 0 { | ||
| if r.Authoritative || len(r.Answer) > 0 { |
There was a problem hiding this comment.
The comment now does not match the logic:
not-authorative or no answer
<=> !r.Authoritative || len(r.Answer)==0
<=> !(r.Authoritative && len(r.Answer)>0)
|
Closed in favour of #307. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a logic bug introduced with the refactoring of the external
resolver code: 31f5539
The bug manifested when external queries would be sent to configured resolvers
that would reply with non-authoritative answers. These answers weren't
considered valid and if the message would contain an SOA record in its
authoritative section then it would be erroneously recursed.