state: Refactor Task IP sourcing #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @jdef |
tsenart
force-pushed
the
read-networkinfo-suggestion
branch
from
6710116
to
77da914
Compare
| @@ -1,11 +1,13 @@ | |||
| package state | |||
| package state_test | |||
There was a problem hiding this comment.
what is the advantage of doing this?
There was a problem hiding this comment.
Privacy enforcement.
There was a problem hiding this comment.
Package state_test has no access to private identifiers of package state.
There was a problem hiding this comment.
that's pretty interesting. i'm wondering if I can use this in the k8s-mesos "km" main package since it looks like the _test.go stuff in package main is bleeding into the generated non-test executable.
|
very elegant. some concerns about aggregation of IPs. |
This commit refactors the Task IP sourcing code to gracefully account for the new `NetworkInfo` source with the same structure and be easily changed to distinguish between IPv4 and IPv6.
tsenart
force-pushed
the
read-networkinfo-suggestion
branch
from
77da914
to
6e0b1ae
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the Task IP sourcing code to gracefully account
for the new
NetworkInfosource with the same structure and be easilychanged to distinguish between IPv4 and IPv6.