Skip to content

Commit

Permalink
detect: add TODO for refactoring towards Address.ip
Browse files Browse the repository at this point in the history
  • Loading branch information
Sergiusz Urbaniak committed Sep 29, 2015
1 parent 381b201 commit 5e3a592
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions detect/masters.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ func validMasterInfo(info *mesos.MasterInfo) bool {
func masterHostPort(info *mesos.MasterInfo) string {
// unpack IPv4
octets := make([]byte, net.IPv4len)
// TODO(sur): refactor to use the Address.ip string field once available
binary.LittleEndian.PutUint32(octets, info.GetIp())
// we're using an octet slice of len IPv4len, thus no need to convert with To4()
ipv4 := net.IP(octets)
Expand Down

0 comments on commit 5e3a592

Please sign in to comment.