kommander: Fixes to the clusters summary dashboard #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracedo
requested review from
branden,
GoelDeepak,
hectorj2f,
shaneutt and
alejandroEsc
hectorj2f
approved these changes
Feb 25, 2020
joejulian
approved these changes
Feb 25, 2020
stable/kommander/templates/grafana/dashboards/k8s-resources-clusters.yaml
Show resolved
Hide resolved
mesosphere-teamcity
pushed a commit
that referenced
this pull request
Feb 25, 2020
…: Fix managed cluster count graph * kommander: Bump chart version * kommander: Change clusters dashboard uid * kommander: Use dashboard name for home dashboard job * kommander: Add [Global] suffix to clusters dashbaord name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the cluster summary dashboard which wasn't getting automatically imported correctly (reworked the query to use the same datasource instead of trying to use two on the same dashboard which seems to be causing issues) and also added
[Global]to the dashboard name and changed the uid so it's different from the konvoy-equivalent dashboard's name/uid (just to avoid potential name and uid collisions if someone were to ever deploy a grafana that pulls in both sets of dashboards).I'll be opening another PR later today adding more central dashboards (porting over the base k8s dashboards from konvoy), wanted to keep them separate since this one's a bug fix.