Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to Mapbox API V10 #368

Merged

Conversation

PWRxPSYCHO
Copy link
Member

@PWRxPSYCHO PWRxPSYCHO commented Feb 5, 2022

Part 1 of issue #359

Working on the migration to V10 of MapBox

Key things to note in this PR:

  • Min SDK version has been bumped from 15 to 21
  • com.github.mik3y:usb-serial-for-android has been updated from v3.0.0 to v3.4.3 (This might cause issues so we can attempt to revert if necessary)

Work that has been completed:

  • Upgraded MapBox dependency
  • Updated map_view.xml to reference to new version
  • Updated the rendering of MapBox in the MapFragment.kt file
  • Updated adding Layers, Source, & Image to Layer View
  • Updated Gesture Control
  • Updated Nodes Position
  • Updated Camera Movement (and initial load zoom level)
  • Removed old dependency

I do not have 2 GPS capable devices to test multiple nodes. So that should be tested before this gets merged. If there are any issues I would recommend whoever has the devices makes the changes so that it can be tested more efficiently.

@PWRxPSYCHO PWRxPSYCHO marked this pull request as ready for review February 6, 2022 03:30
@andrekir andrekir linked an issue Feb 6, 2022 that may be closed by this pull request
@andrekir
Copy link
Member

andrekir commented Feb 6, 2022

thank you!

@andrekir andrekir merged commit 1f177dc into meshtastic:master Feb 6, 2022
@PWRxPSYCHO PWRxPSYCHO deleted the feature/mapbox-v10-migration branch February 6, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes sometimes when opening map
2 participants